-
Notifications
You must be signed in to change notification settings - Fork 13.4k
mtmd : Fix/Add non-ASCII file path support on Windows #16609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kuguma
wants to merge
8
commits into
ggml-org:master
Choose a base branch
from
axinc-ai:fix-mtmd-filepath-encoding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an unintended change in the PR. |
ngxson
reviewed
Oct 17, 2025
tools/mtmd/mtmd-helper.cpp
Outdated
FILE * f = fopen(fname, "rb"); | ||
if (!f) { | ||
LOG_ERR("Unable to open file %s: %s\n", fname, strerror(errno)); | ||
fprintf(stderr, "Unable to open file %s: %s\n", fname, strerror(errno)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we cannot use LOG_ERR
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to use LOG_ERR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed path handling in the mtmd feature on Windows to correctly convert and process non-ASCII file paths.
Additionally, fixed a missing console initialization in mtmd-cli.
Issues Resolved
Failed to load .mmproj files with non-ASCII file paths
Failed to load image files with non-ASCII file paths
Incorrect path parsing in mtmd-cli when using
/image <filepath>
with non-ASCII charactersComparison of behavior
Windows 11 Pro 24H2
b6756
This PR
Notes
The general argument-handling logic in llama.cpp also has issues with non-ASCII paths.
Since the impact area is broad, I will submit a separate PR to address this.