SYCL: Add support for FLOOR,CEIL,ROUND and TRUNC unary operators #16613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
There's a bad merge or something, you are touching a lot of unrelated code. |
This was referenced Oct 16, 2025
|
Thank you for the feedback! You're absolutely right — it looks like some
unrelated changes ended up in this PR, likely due to an incorrect merge or
leftover WIP.
I'll clean it up and rebase the branch to ensure it only includes the
intended SYCL support for floor, ceil, round, and trunc.
בתאריך יום ה׳, 16 באוק׳ 2025 ב-14:23 מאת Sigbjørn Skjæret <
***@***.***>:
… *CISC* left a comment (ggml-org/llama.cpp#16613)
<#16613 (comment)>
There's a bad merge or something, you are touching a lot of unrelated code.
—
Reply to this email directly, view it on GitHub
<#16613 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BT72BRODH2N23TYYM4LQIK33X552BAVCNFSM6AAAAACJLNIRJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMJQGM4TSNRXGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
CISC
reviewed
Oct 16, 2025
CISC
reviewed
Oct 16, 2025
CISC
reviewed
Oct 16, 2025
safranowith
force-pushed
the
add-operators-sycl
branch
from
3a3dd1d to
d7ded21
Compare
|
I've cleaned up the unrelated changes — let me know if everything looks
good now or if there's anything else I should fix.
בתאריך יום ה׳, 16 באוק׳ 2025 ב-15:09 מאת Sigbjørn Skjæret <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In ggml/include/ggml.h
<#16613 (comment)>:
> @@ -1462,7 +1494,6 @@ extern "C" {
struct ggml_context * ctx,
struct ggml_tensor * a,
struct ggml_tensor * b);
-
and here
------------------------------
In ggml/include/ggml.h
<#16613 (comment)>:
> @@ -1941,7 +1972,6 @@ extern "C" {
int p1, // padding dimension 1
int d0, // dilation dimension 0
int d1); // dilation dimension 1
-
and here
------------------------------
In ggml/include/ggml.h
<#16613 (comment)>:
> @@ -1976,7 +2006,6 @@ extern "C" {
int d1, // dilation height
int d2 // dilation depth
);
-
and here
------------------------------
In ggml/include/ggml.h
<#16613 (comment)>:
> -
+
and here
—
Reply to this email directly, view it on GitHub
<#16613 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BT72BRPLMUUIAIBI425B4ED3X6DHFAVCNFSM6AAAAACJLNIRJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBUGQ4TCNRVG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
CISC
reviewed
Oct 16, 2025
|
Is everything in order now? Please let me know if any further changes are
needed.
בתאריך יום ה׳, 16 באוק׳ 2025 ב-15:41 מאת Sigbjørn Skjæret <
***@***.***>:
… ***@***.**** commented on this pull request.
Let's try again. :)
------------------------------
In ggml/include/ggml.h
<#16613 (comment)>:
> +
GGML_API struct ggml_tensor * ggml_pad_ext(
struct ggml_context * ctx,
struct ggml_tensor * a,
+
int lp0,
⬇️ Suggested change
-
- GGML_API struct ggml_tensor * ggml_pad_ext(
- struct ggml_context * ctx,
- struct ggml_tensor * a,
-
- int lp0,
+
+ GGML_API struct ggml_tensor * ggml_pad_ext(
+ struct ggml_context * ctx,
+ struct ggml_tensor * a,
+ int lp0,
—
Reply to this email directly, view it on GitHub
<#16613 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BT72BRKOZBOQ5JEFNJLGXYT3X6HAPAVCNFSM6AAAAACJLNIRJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBUGYZTSMZVG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Clean up unrelated changes from previous commit
safranowith
force-pushed
the
add-operators-sycl
branch
from
c7e5d6e to
cdbc950
Compare
NeoZhangJianyu
approved these changes
Oct 17, 2025
ggerganov
requested changes
Oct 17, 2025
Comment on lines
+1107
to
+1139
| GGML_API struct ggml_tensor * ggml_floor( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_floor_inplace( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_ceil( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_ceil_inplace( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_round( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_round_inplace( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_trunc( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
| GGML_API struct ggml_tensor * ggml_trunc_inplace( | ||
| struct ggml_context * ctx, | ||
| struct ggml_tensor * a); | ||
|
|
||
|
|
There was a problem hiding this comment.
These are not needed - the declarations are already in the header a few lines further down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following unary operators in the SYCL backend:
FLOOR, CEIL, ROUND, TRUNC.
Changes include:
Implementation in element_wise.cpp and element_wise.hpp
Header updates in ggml.h
Registration in SYCL.csv
Documentation updates in docs/ops.md
Test coverage in test-backend-ops.cpp
This SYCL implementation was added following the prior addition of the same operators in the CPU backend.