vulkan: fix debug build (add_rms_len/data not found) #16624
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vulkan
jeffbolznv
commented
Oct 16, 2025
|
|
||
| std::string suffixes[2] = {"_f32", "_f16"}; | ||
| for (auto op : {"add", "sub", "mul", "div", "add_rms"}) { | ||
| for (std::string op : {"add", "sub", "mul", "div", "add_rms"}) { |
There was a problem hiding this comment.
I had written the comparison at line 966 as if it was a string comparison, but it was a char*. I guess we got away with it in release builds but not debug builds.
There was a problem hiding this comment.
Fixed my issue when compile on Visual C++ 2022.
This should immdiately merged into ggml 0.9.4.
0cc4m
approved these changes
Oct 17, 2025
|
I can confirm replacing Kudos @jeffbolznv, I have been staring at the code and this is really not obvious to spot... Great catch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16502.