Fix: validateNewFunctionWithConstantArguments:305: failed assertion constantValues must not be nil.' #16639
+132
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my issue at #16564, I've create a pull request with a fix. I've tested this locally as written in the Contributing.md, and it works perfectly. The validateNewFunctionWithConstantArguments:305: failed assertion constantValues must not be nil.' no longer shows up when sending a message on iOS with the XCFramework.
This commit:
Adds a resilient wrapper around MTLFunctionConstantValues that records every constant assignment so they can be replayed whenever the underlying Metal object needs to be recreated. Additionaly, this commit hardens pipeline compilation by rebuilding the constant-values container on demand, reapplying cached constants, and warning before falling back to compiling the kernel without constants instead of hard-failing.
This: