Skip to content

Conversation

JohannesGaessler
Copy link
Collaborator

When setting AMD GPU architectures via AMDGPU_TARGETS, you get the following warning:

CMake Warning (dev) at /opt/rocm/lib/cmake/hip/hip-config-amd.cmake:70 (message):
  AMDGPU_TARGETS is deprecated.  Please use GPU_TARGETS instead.
Call Stack (most recent call first):
  /opt/rocm/lib/cmake/hip/hip-config.cmake:149 (include)
  ggml/src/ggml-hip/CMakeLists.txt:41 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

This warning does not originate from within ggml, if you then try to set GPU_TARGETS as suggested it doesn't work because we are currently setting CMAKE_HIP_ARCHITECTURES based on AMDGPU_TARGETS only. This PR simply adds the same logic for GPU_TARGETS.

@github-actions github-actions bot added devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning labels Oct 17, 2025
Copy link
Collaborator

@IMbackK IMbackK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jup that works, looks good.

@JohannesGaessler JohannesGaessler merged commit ee09828 into ggml-org:master Oct 18, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants