Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting AMD GPU architectures via
AMDGPU_TARGETS
, you get the following warning:This warning does not originate from within ggml, if you then try to set
GPU_TARGETS
as suggested it doesn't work because we are currently settingCMAKE_HIP_ARCHITECTURES
based onAMDGPU_TARGETS
only. This PR simply adds the same logic forGPU_TARGETS
.