Skip to content

Conversation

am17an
Copy link
Collaborator

@am17an am17an commented Oct 18, 2025

Uses the technique used in the vulkan PR #16641. Neat trick!

Uses the technique used in the vulkan PR ggml-org#16641. Neat trick!
@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Oct 18, 2025
@am17an
Copy link
Collaborator Author

am17an commented Oct 18, 2025

I am not able to restart tests for CI, The nvidia-cuda test is failing with

The self-hosted runner lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

I'd rather not push another commit to trigger the CI again. @ggerganov is this a permission issue and can it be changed?

@JohannesGaessler
Copy link
Collaborator

If one first clicks on a job and then one of the buttons it is possible to manually re-run it. Since permissions were recently tightened I don't know whether you could do that yourself though (I just did).

@am17an
Copy link
Collaborator Author

am17an commented Oct 18, 2025

If one first clicks on a job and then one of the buttons it is possible to manually re-run it. Since permissions were recently tightened I don't know whether you could do that yourself though (I just did).

Yes I was able to do that earlier as well

@JohannesGaessler JohannesGaessler merged commit 38355c6 into ggml-org:master Oct 18, 2025
125 of 126 checks passed
@ggerganov
Copy link
Member

@am17an It seems that approving workflows requires write access, so I just loosened up the approval requirement to "first-time contributors" from "all external contributors":

image

Your workflows should always run now without additional approval.

If this becomes too heavy for the CI or we think it can become a security concern, we might switch back to manual workflow approval for all PRs.

@am17an
Copy link
Collaborator Author

am17an commented Oct 18, 2025

Thanks. Seems like "collaborator" is not a well thought design by Github, my intuition would be a collaborator would be able to run workflows on their own PRs (at the least)

@am17an am17an deleted the cuda_topk_optimize branch October 18, 2025 10:21
@am17an
Copy link
Collaborator Author

am17an commented Oct 18, 2025

Actually I'm still not able to re-run jobs. This is the screen I see
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants