Skip to content

Conversation

@ericcurtin
Copy link
Collaborator

So we can pull from any OCI registry, add authentication, etc.

Add docker-style progress bars and resumable downloads to OCI pulls

Update documentation with progress bars and resumable downloads info

@ericcurtin ericcurtin requested a review from ggerganov as a code owner October 19, 2025 15:52
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 19, 2025
@ericcurtin
Copy link
Collaborator Author

@ggerganov I think you'll find this interesting, it's an improved version of:

#15790

@ericcurtin ericcurtin force-pushed the integrate-go-containerregistry-library branch 8 times, most recently from 48475af to e4b192d Compare October 19, 2025 20:18
So we can pull from any OCI registry, add authentication, etc.

Add docker-style progress bars and resumable downloads to OCI pulls

Update documentation with progress bars and resumable downloads info

Make OCI Go build optional and skip editorconfig for oci-go

Add Go version check before building OCI library

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin ericcurtin force-pushed the integrate-go-containerregistry-library branch from e4b192d to 2935963 Compare October 19, 2025 20:47
@ggerganov
Copy link
Member

I don't think we want to introduce Go in the codebase. Also I don't understand really well what functionality this would enable, so can't review this in a meaningful way.

@ericcurtin
Copy link
Collaborator Author

ericcurtin commented Oct 20, 2025

I don't think we want to introduce Go in the codebase. Also I don't understand really well what functionality this would enable, so can't review this in a meaningful way.

Ok, I will halt, unless people change their mind, I was working on making this optional like Rust is optional in the kernel, it would move to this library for pulling models from Docker Hub:

https://github.com/google/go-containerregistry

This ensures we can pull (and maybe even push) models to any OCI registry ghcr.io, quay.io, Docker Hub,
JFrog Artifactory, etc. And that we can login/authenticate with those if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants