llama: add linearly increasing token dim for M-RoPE #16822
                
     Closed
            
            
          
      
        
          +99
        
        
          −51
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Important
This is still WIP
Supersede #15474 and #16745
Fix #13694
In this PR, I try to add one more dimension to
llama_batch.poswhen using M-RoPE. This is exactly the solution illustrated in this comment: #15474 (comment) , but currently only the image batch has this extra dimThe output is more accurate now, using the same test from #13694
TODO: add the same dim to text batch