docs: explain CUDA 11 compilation [no ci] #16824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CISC
approved these changes
Oct 28, 2025
Comment on lines
205
to
221
| ```C++ | ||
| // original lines | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double cospi(double x); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float cospif(float x); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double sinpi(double x); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float sinpif(float x); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double rsqrt(double x); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float rsqrtf(float x); | ||
|
|
||
| // edited lines | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double cospi(double x) noexcept (true); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float cospif(float x) noexcept (true); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double sinpi(double x) noexcept (true); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float sinpif(float x) noexcept (true); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double rsqrt(double x) noexcept (true); | ||
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float rsqrtf(float x) noexcept (true); | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ```C++ | |
| // original lines | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double cospi(double x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float cospif(float x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double sinpi(double x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float sinpif(float x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double rsqrt(double x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float rsqrtf(float x); | |
| // edited lines | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double cospi(double x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float cospif(float x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double sinpi(double x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float sinpif(float x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double rsqrt(double x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float rsqrtf(float x) noexcept (true); | |
| ``` | |
| ```C++ | |
| // original lines | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double cospi(double x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float cospif(float x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double sinpi(double x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float sinpif(float x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double rsqrt(double x); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float rsqrtf(float x); | |
| // edited lines | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double cospi(double x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float cospif(float x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double sinpi(double x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float sinpif(float x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ double rsqrt(double x) noexcept (true); | |
| extern __DEVICE_FUNCTIONS_DECL__ __device_builtin__ float rsqrtf(float x) noexcept (true); |
Collaborator
There was a problem hiding this comment.
Doesn't show on the diff, but there are whitespaces...
Collaborator
Author
There was a problem hiding this comment.
Thank you, I have my IDE configured to remove trailing whitespaces automatically so if it doesn't for a pre-formatted block I don't think of it :)
JohannesGaessler
force-pushed
the
cuda-11-fix
branch
from
dc9f3fd to
18995ae
Compare
github-actions
bot
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some technical issues when trying to compile llama.cpp for CUDA 11.7 on Manjaro, this PR adds the steps I had to take to the build documentation.