llama: fix ASAN error with M-RoPE #16848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
commented
Oct 29, 2025
| udata->pos[j*n_tokens + i] = batch.pos[j*batch.n_tokens + idxs[i]]; | ||
| for (size_t j = 0; j < (size_t)n_pos_per_embd; ++j) { | ||
| // if we are using M-RoPE | ||
| // if the current batch is text, we need to broadcast the same position across all RoPE sections |
There was a problem hiding this comment.
please note that even though only 3 dims are used in QwenVL (while n_pos_per_embd = 4), the last dim is never actually processed by ggml, as its hparams.mrope_section will be 0. Therefore, it's safe to broadcast the all dims here.
ggerganov
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #16825
I forgot to re-enable ASAN on my build, so I didn't catch this error on the initial PR.