Skip to content

Fix segfault in moe-expert-reduce test in support mode and coverage #16936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2025
+19 −0
Merged

Fix segfault in moe-expert-reduce test in support mode and coverage #16936

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf26680
tests: fix segfault in moe-expert-reduce test in support mode and --s…
sbera77 Nov 2, 2025
e78ca2e
tests: init gf and filter out fusion tests for support mode
sbera77 Nov 2, 2025
c3cb20b
tests: filter out fusion cases before calling eval_support
sbera77 Nov 2, 2025
2eeb1c1
tests: filter out fusion cases from show_test_coverage as well, fix lint
sbera77 Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/test-backend-ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,6 +1454,8 @@ struct test_case {
ggml_context_ptr ctx(ggml_init(params)); // smart ptr
GGML_ASSERT(ctx);

gf = ggml_new_graph_custom(ctx.get(), graph_nodes, false);

ggml_tensor * out = build_graph(ctx.get());
current_op_name = op_desc(out);

Expand Down Expand Up @@ -4844,7 +4846,9 @@ struct test_moe_expert_reduce : public test_case {

std::string name = "expert_view_" + std::to_string(i);
ggml_set_name(expert_views[i], name.c_str());
ggml_build_forward_expand(gf, expert_views[i]);
if (gf) {
ggml_build_forward_expand(gf, expert_views[i]);
}
}

ggml_tensor * moe_out = expert_views[0];
Expand Down Expand Up @@ -7569,6 +7573,15 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
if (mode == MODE_SUPPORT) {
auto test_cases = make_test_cases_eval();
filter_test_cases(test_cases, params_filter);

// Filter out fusion cases
test_cases.erase(
std::remove_if(test_cases.begin(), test_cases.end(), [](const std::unique_ptr<test_case>& tc) {
return tc->run_whole_graph();
}),
test_cases.end()
);

for (auto & test : test_cases) {
test->eval_support(backend, op_names_filter, output_printer);
}
Expand Down
Loading