-
Notifications
You must be signed in to change notification settings - Fork 13.7k
CUDA: fix should_use_mmvf for ne11 == 1 #17085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JohannesGaessler
merged 2 commits into
ggml-org:master
from
JohannesGaessler:cuda-fix-should_use_mmvf
Nov 7, 2025
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -720,12 +720,19 @@ bool ggml_cuda_should_use_mmvf(enum ggml_type type, int cc, const int64_t * src0 | |||
| if (src0_ne[0] % 2 != 0) { | ||||
| return false; | ||||
| } | ||||
|
|
||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
| const size_t ts = ggml_type_size(type); | ||||
| for (size_t i = 0; i < GGML_MAX_DIMS; ++i) { | ||||
| if (src0_nb[0] != ts) { | ||||
am17an marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
| return false; | ||||
| } | ||||
|
|
||||
| // Pointers not aligned to the size of half2/nv_bfloat162/float2 would result in a crash: | ||||
| for (size_t i = 1; i < GGML_MAX_DIMS; ++i) { | ||||
| if (src0_nb[i] % (2*ts) != 0) { | ||||
| return false; | ||||
| } | ||||
| } | ||||
|
|
||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
| switch (type) { | ||||
| case GGML_TYPE_F32: | ||||
| if (GGML_CUDA_CC_IS_NVIDIA(cc)) { | ||||
|
|
||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.