Skip to content

server: added loading page while model loading #9401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

server: added loading page while model loading #9401

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
dfe31e0
Adding loading page for '/' server requests
VJHack Sep 10, 2024
dab4b49
set content when model is loading
VJHack Sep 11, 2024
19bc863
removed loading html file
VJHack Sep 11, 2024
125737a
updated cmakelist
VJHack Sep 11, 2024
3dd73ca
updated makefile
VJHack Sep 11, 2024
1ff1aa7
cleaned up whitespace
VJHack Sep 11, 2024
9d3424a
cleanup for PR removed error
VJHack Sep 11, 2024
5ca179c
updated server test to handle 503 HTML
VJHack Sep 12, 2024
161bf22
updated server test to handle 503 HTML
VJHack Sep 12, 2024
8b7daaa
ca†ch 503 before parsing json
VJHack Sep 13, 2024
daf64fc
revert test
VJHack Sep 13, 2024
cb13382
account for both api and web browser requests
VJHack Sep 13, 2024
42abdd0
precommit corrections
VJHack Sep 13, 2024
69c97bb
Merge branch 'ggerganov:master' into master
VJHack Sep 13, 2024
cd80fce
eol fix
VJHack Sep 13, 2024
e51eb59
revert changes to pre-commit
VJHack Sep 13, 2024
df9f167
removed print statement
VJHack Sep 13, 2024
739ea75
made loading message more descriptive
VJHack Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions examples/server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2592,10 +2592,15 @@ int main(int argc, char ** argv) {
return false;
};

auto middleware_server_state = [&res_error, &state](const httplib::Request &, httplib::Response & res) {
auto middleware_server_state = [&res_error, &state](const httplib::Request & req, httplib::Response & res) {
server_state current_state = state.load();
if (current_state == SERVER_STATE_LOADING_MODEL) {
res_error(res, format_error_response("Loading model", ERROR_TYPE_UNAVAILABLE));
if(req.path == "/"){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing one requirement from the original issue #9158

Here only / is catched, not *.html. I leave a suggestion on my comment #9401 (comment) , but I'll apply it myself.

res.set_content("<html><body>The model is loading. Please wait.<br/>The user interface will appear soon.<br/>You may need to refresh the page.</body></html>", "text/html; charset=utf-8");
res.status = 503;
} else {
res_error(res, format_error_response("Loading model", ERROR_TYPE_UNAVAILABLE));
}
return false;
}
return true;
Expand Down
Loading