Skip to content

Added support for SFTTrainer checkpoint models and adapter models containing some non-LoRA weights #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added support for SFTTrainer checkpoint models and adapter models containing some non-LoRA weights #9778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6396aa
Added support for SFTTrainer checkpoint models and adapter models con…
Victoran0 Oct 8, 2024
c2c2626
Added support for SFTTrainer checkpoint models and adapter models con…
Victoran0 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions convert_lora_to_gguf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,27 +339,28 @@ def get_tensors(self) -> Iterator[tuple[str, Tensor]]:
tensor_map: dict[str, PartialLoraTensor] = {}

for name, tensor in lora_model.items():
if self.lazy:
tensor = LazyTorchTensor.from_eager(tensor)
base_name = get_base_tensor_name(name)
is_lora_a = ".lora_A.weight" in name
is_lora_b = ".lora_B.weight" in name
if not is_lora_a and not is_lora_b:
if ".base_layer.weight" in name:
continue
logger.error(f"Unexpected name '{name}': Not a lora_A or lora_B tensor")
sys.exit(1)

if base_name in tensor_map:
if is_lora_a:
tensor_map[base_name].A = tensor
if ("lora_" in name) or (".base_layer.weight" in name):
if self.lazy:
tensor = LazyTorchTensor.from_eager(tensor)
base_name = get_base_tensor_name(name)
is_lora_a = ".lora_A.weight" in name
is_lora_b = ".lora_B.weight" in name
if not is_lora_a and not is_lora_b:
if ".base_layer.weight" in name:
continue

if base_name in tensor_map:
if is_lora_a:
tensor_map[base_name].A = tensor
else:
tensor_map[base_name].B = tensor
else:
tensor_map[base_name].B = tensor
if is_lora_a:
tensor_map[base_name] = PartialLoraTensor(A=tensor)
else:
tensor_map[base_name] = PartialLoraTensor(B=tensor)
else:
if is_lora_a:
tensor_map[base_name] = PartialLoraTensor(A=tensor)
else:
tensor_map[base_name] = PartialLoraTensor(B=tensor)
pass

for name, tensor in tensor_map.items():
assert tensor.A is not None
Expand Down