Skip to content

server: fix the disappearance of the end of the text when streaming with stop strings #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2024
Merged

server: fix the disappearance of the end of the text when streaming with stop strings #9867

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae996a2
server: fix the disappearance of the end of the text when streaming w…
z80maniac Oct 12, 2024
40a68f4
simplify "send text" checks
z80maniac Oct 14, 2024
6e13d3f
Merge remote-tracking branch 'upstream/master' into fix-stop-trim
z80maniac Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ struct server_context {
}

// check if there is any token to predict
if (stop_pos == std::string::npos || (!slot.has_next_token && !is_stop_full && stop_pos > 0)) {
if (stop_pos == std::string::npos || is_stop_full || (!slot.has_next_token && !is_stop_full && stop_pos > 0)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this if will always evaluate to true:

  • if stop_pos == std::string::npos -> true
  • if stop_pos != std::string::npos, then is_stop_full == true due to line 1075 -> true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have attempted to simplify this logic in the new commit. The text will not be sent only when the partial match is found. And partial match will be searched for only when the current token is not the last one.

// no send the stop word in the response
result.text_to_send = slot.generated_text.substr(pos, std::string::npos);
slot.n_sent_text += result.text_to_send.size();
Expand Down
Loading