Skip to content

Conversation

@kylo5aby
Copy link
Contributor

Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also reset token_count in llama_sampler_penalties_reset()

@kylo5aby
Copy link
Contributor Author

Need to also reset token_count in llama_sampler_penalties_reset()

Resolved.

Comment on lines 1404 to 1406
if (ctx->prev.size() >= (size_t) ctx->penalty_last_n) {
if (--ctx->token_count[ctx->prev.front()] == 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an assert here would be worth it as a sanity check:

Suggested change
if (ctx->prev.size() >= (size_t) ctx->penalty_last_n) {
if (--ctx->token_count[ctx->prev.front()] == 0) {
if (ctx->prev.size() >= (size_t) ctx->penalty_last_n) {
assert(ctx->token_count.at(ctx->prev.front()) > 0);
if (--ctx->token_count[ctx->prev.front()] == 0) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants