ruby : Fix of C++ header guard name, model URI support, type signature and more #2683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Fix argument of rb_undefine_finalizer"
ggerganov
approved these changes
Dec 30, 2024
|
Thanks for your adjustment of an affected include guard. |
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Jan 8, 2025
* ggerganov/master: make : fix "main" -> "whisper-cli" ci : re-enable Windows cublas build (ggml-org#2676) ruby : Fix of C++ header guard name, model URI support, type signature and more (ggml-org#2683) examples : handle "main.exe" deprecation
lyapple2008
pushed a commit
to lyapple2008/whisper.cpp.mars
that referenced
this pull request
Feb 4, 2025
…e and more (ggml-org#2683) * Add test to make Whisper::Context.new accept URI string * Add test to make Whisper::Context.new accept URI * Make Whisper::Context.new accept URI string and URI * Update README Revert "Fix argument of rb_undefine_finalizer" * Fix typos * Add type signature file * Assign literarl to const variable * Load Whisper::Model::URI from Init_whisper * Simplify .gitignore * Don't load whisper.so from whisper/model/uri.rb * Use each_with_object instead of each * Add Development section to README * Rename header guard to conform to C++ naming convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request
Whisper::Context.newaccept URI for model file,Thank you.