Skip to content

ruby : Make context accept initial parameters, API to retrieve a segment and more #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggerganov merged 31 commits into from
Jan 21, 2025
Merged

ruby : Make context accept initial parameters, API to retrieve a segment and more #2749

ggerganov merged 31 commits into from
Jan 21, 2025

Conversation

@KitaitiMakoto
Copy link
Collaborator

@KitaitiMakoto KitaitiMakoto commented Jan 18, 2025 •
edited
Loading

Hello,

This pull request

  • makes Whisper::Context.new accept initial parameters,
  • adds to retrieve to a segment to Whisper::Context,
  • splits a C++file into multiple files,
  • and includes tiny refinements

Thanks.

@KitaitiMakoto
Fix type signature for Whisper.log_set
c1ebdce
@KitaitiMakoto
Use cache file for model when offline
5a1745e
@KitaitiMakoto
Extract ruby_whisper_transcribe() into a file
af27378
@KitaitiMakoto
Extract Whisper::Error
d9b09fa
@KitaitiMakoto
Use FileList for ext/*.{c,cpp,h}
61c6cf3
@KitaitiMakoto
Extract Whisper::Segment
f3c71da
@KitaitiMakoto
Extract Whisper::Model
7d2dc07
@KitaitiMakoto
Extract Whisper::Params
e3a8935
@KitaitiMakoto
Extract Whisper::Context
ab1353a
@KitaitiMakoto
Extract log_callback function
e11f598
@KitaitiMakoto
Write base code in C rather than C++
88e65e2
@KitaitiMakoto
Use chdir instead of Dir.chdir in Rakefile
c436804
@KitaitiMakoto
Define alloc func for Whisper::Model
5ab326d
@KitaitiMakoto
Define Whisper::Params' calback and user data reader
efa18bb
@KitaitiMakoto
Add test for Whisper::Params.new with keyword arguments
2b2dd5e
@KitaitiMakoto
Make Whisper::Params.new accept keyword arguments
744b64e
@KitaitiMakoto
Update type signatures
30f3c9d
@KitaitiMakoto
Update README
9061843
@KitaitiMakoto
Update CLEAN targets
6eb114f
@KitaitiMakoto
Fix document comment for Whisper::Params#new_segment_callback=
31a33a8
@KitaitiMakoto
Use macro to define params
41eaec7
@KitaitiMakoto
Fix dependency of build task
86604aa
@KitaitiMakoto
Set Whisper.finalize_log_callback visibility to private
3f85151
@KitaitiMakoto
Make Whisper::Context#full and full_parallel return self
0a52548
@KitaitiMakoto
Add test for Whisper::Context#full_get_segment
324b8d4
@KitaitiMakoto
Add Whisper::Context#full_get_segment
418d519
@KitaitiMakoto
Update signatures
3e0b52a
@KitaitiMakoto
Update README
510ef4c
@KitaitiMakoto
Fix signature
9c9bcfc
@KitaitiMakoto
Resplace #initialize with .new in signature file [skip ci]
7ee9983
ggerganov
ggerganov approved these changes Jan 20, 2025
View reviewed changes
bindings/ruby/ext/ruby_whisper_transcribe.cpp Outdated
}
} else {
for (uint64_t i = 0; i < n; i++) {
pcmf32[i] = float(pcm16[2*i] + pcm16[2*i + 1])/65536.0f;
Copy link
Member

@ggerganov ggerganov Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can overflow int16_t

Copy link
Collaborator Author

@KitaitiMakoto KitaitiMakoto Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! I fixed it. I appreciate if you tell me better way because I'm a newbie to C++.

Copy link
Member

@ggerganov ggerganov Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK.

Copy link
Collaborator Author

@KitaitiMakoto KitaitiMakoto Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggerganov ggerganov merged commit 7ffcd05 into ggml-org:master Jan 21, 2025
44 checks passed
@KitaitiMakoto KitaitiMakoto deleted the params-kwargs branch January 21, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KitaitiMakoto @ggerganov