Skip to content

Conversation

KitaitiMakoto
Copy link
Collaborator

Hello,

This pull request makes Ruby bindings follow audio library change introduced at #2759 and then makes CI fixed.

Thanks.

Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, it would be better if the Ruby bindings start using CMake to build the ggml/whisper.cpp, instead of replicating the build with Makefiles.

@ggerganov ggerganov merged commit c42f67e into ggml-org:master Feb 28, 2025
44 checks passed
@KitaitiMakoto KitaitiMakoto deleted the fix-ruby-build branch March 2, 2025 06:37
@KitaitiMakoto
Copy link
Collaborator Author

I think so, though it will take several weeks for me to learn CMake.

@ggerganov
Copy link
Member

Just to clarify, I mean that most likely the Makefile that you generate can be replaced by a single call to a cmake command. Not that you need to write CMake scripts - just use the existing CMake build system for the project.

@KitaitiMakoto
Copy link
Collaborator Author

Ah, I see. Thanks!

joelvaneenwyk pushed a commit to joelvaneenwyk/whisper-cpp that referenced this pull request Mar 3, 2025
* Enable CPU

* Follow audio lib change
@houyuanjie
Copy link

I think so, though it will take several weeks for me to learn CMake.

Hi @KitaitiMakoto,
I'm sorry if I bothered you, please take a look at this template repository houyuanjie/learn_cmake_ruby, it may give you some help.

@KitaitiMakoto
Copy link
Collaborator Author

@houyuanjie
Great! I didn't know

spec.extensions = ["ext/learn_cmake_ruby/CMakeLists.txt"]

is effective. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants