examples : reduce initial memory to 512MB #2939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces the initial memory size to 256MB. This is done to to avoid WebAssembly memory allocation issues on some platforms. It also adds a flag to allow the memory to grow dynamically (up to the maximum). The motivation for this change is that currently the initial memory is set to 2GB which might be to large for some platforms. This will lead to an error being thrown from the JavaScript code generated by Emscripten when trying to allocate memory. More details can be found in the referenced issue below. Refs: ggml-org#2920
This commit sets MAXIMUM_MEMORY instead of TOTAL_MEMORY in the whisper.wasm example. The motivation for this is that TOTAL_MEMORY and INITIAL_MEMORY are actually the same thing. Instead we want to set MAXIMUM_MEMORY to 2GB. I've also increased the INITIAL_MEMORY to 512MB as I think we need more after some testing. Refs: https://emscripten.org/docs/tools_reference/settings_reference.html#initial-memory
ggerganov
approved these changes
Mar 24, 2025
danbev
changed the title
buxuku
pushed a commit
to buxuku/whisper.cpp
that referenced
this pull request
Mar 26, 2025
* examples : reduce initial memory to 512MB This commit reduces the initial memory size to 512MB. This is done to to avoid WebAssembly memory allocation issues on some platforms. It also adds a flag to allow the memory to grow dynamically (up to the maximum). The motivation for this change is that currently the initial memory is set to 2GB which might be to large for some platforms. This will lead to an error being thrown from the JavaScript code generated by Emscripten when trying to allocate memory. More details can be found in the referenced issue below. * examples : set MAXIMUM_MEMORY instead of TOTAL_MEMORY This commit sets MAXIMUM_MEMORY instead of TOTAL_MEMORY in the whisper.wasm example. The motivation for this is that TOTAL_MEMORY and INITIAL_MEMORY are actually the same thing. Instead we want to set MAXIMUM_MEMORY to 2GB. Refs: ggml-org#2920 Refs: https://emscripten.org/docs/tools_reference/settings_reference.html#initial-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the initial memory size to 512MB. This is done to to avoid WebAssembly memory allocation issues on some platforms. It also adds a flag to allow the memory to grow dynamically (up to the maximum).
The motivation for this change is that currently the initial memory is set to 2GB which might be to large for some platforms. This will lead to an error being thrown from the JavaScript code generated by Emscripten when trying to allocate memory. More details can be found in the referenced issue below.
Refs: #2920