ci : re-enable bindings-java (java) job #2956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-enables the job previously name `java` which was disabled in the build.yml file. The motivation for this is that we recently fixed a few issue in the java bindings and it should be possible to build them on windows. Refs: ggml-org#2949 Refs: ggml-org#2781
Add a condition to the bindings-java job to only run when the event is a push, pull_request, or the run_type is full-ci.
Update directory for windows dll.
Rename the downloaded (from github workflow storage) .dll to whisper.dll as this is what WhisperCppJnaLibrary expects.
The motivation for this is that there is a gradle task that copies the dll from this location and hopefully this will work in github actions too as I'm struggling to get this to work.
|
I'm going to close this and revisit when I have a windows environment setup so I can test this locally. Sorry about all the noise of failing CI builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-enables the job previously name
javawhich was disabled in the build.yml file.The motivation for this is that we recently fixed a few issue in the java bindings and it should be possible to build them on windows.
Refs: #2949
Refs: #2781