cmake: improve Vulkan cooperative matrix support checks #2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandoti
approved these changes
Mar 30, 2025
| set(GGML_VULKAN_COOPMAT_GLSLC_SUPPORT ON CACHE INTERNAL "Whether coopmat is supported by glslc") | ||
| endif() | ||
| else() | ||
| message(STATUS "GL_KHR_cooperative_matrix support already defined: ${GGML_VULKAN_COOPMAT_GLSLC_SUPPORT}") |
There was a problem hiding this comment.
Are these status messages required? I am okay with keeping it if you think this is useful. 🙂
There was a problem hiding this comment.
I think they are good indicators. Not strictly required, but they would have made identifying the issue in #2965 a lot easier. It was strange that no GGML_VULKAN_COOPMAT_GLSLC_SUPPORT indicator existed if it was defined externally.
Let me know if you want to remove it (if you think it is too verbose)
|
This is ready to merge? I will then sync it upstream. |
bandoti
approved these changes
Mar 31, 2025
|
Yep looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a small issue if
GGML_VULKAN_COOPMAT_GLSLC_SUPPORTorGGML_VULKAN_COOPMAT2_GLSLC_SUPPORTis defined as option, after ggml-org/llama.cpp#12272The current behaviour will forward it to the
vulkan-shaders-gencmake process but it won't add the compile definition for the main cmake process.If some client will send it as parameter with
-DGGML_VULKAN_COOPMAT_GLSLC_SUPPORT=ONwill result in runtime issues for some hardware, see #2965 for more details.CC: @jeffbolznv , @bandoti