- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.9k
release : v1.7.5 #2994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release : v1.7.5 #2994
Conversation
| Are there instructions for building the swift package? i added the repo but noticed the framework isn't listed when i go to add it to the target | 
| @itsthisjustin The Package.swift file was removed in favor of using the xcframework. For a swift project the xcframework can be used like this: // swift-tools-version: 5.10
// The swift-tools-version declares the minimum version of Swift required to build this package.
import PackageDescription
let package = Package(
    name: "Whisper",
    targets: [
        .executableTarget(
            name: "Whisper",
            dependencies: [
                "WhisperFramework"
            ]),
        .binaryTarget(
            name: "WhisperFramework",
            url: "https://github.com/ggerganov/whisper.cpp/releases/download/v1.7.5/whisper-v1.7.5-xcframework.zip",
            checksum: "c7faeb328620d6012e130f3d705c51a6ea6c995605f2df50f6e1ad68c59c6c4a"
        )
    ]
)I'll make sure we document this somewhere as I don't think we have. Perhaps this should also be included in the release notes moving forward, providing the correct checksum as well. | 
| 
 This is super helpful. I'd say a little guide for us Swift folks could be super useful. This isn't a "standard" way to use a package like this so it's slightly outside of my existing knowledge compared to how it used to work. | 
| Also not sure if unique to me but i couldn't build the script with xros as the visionOS command. I had to change it visionos and then it build the binaries. | 
| 
 Same here, got a  
 | 
| @itsthisjustin @n374 Thanks for reporting this. I'll take a closer look. | 
This commit adds a check for the visionos build version used with vtool in build-xcframework.sh. The script now checks the Xcode version and determines whether to use "xros" or "visionos" for the build version. This commit also uses xcrun for the vtool so that the version of vtool in xcode command line tools is used instead of the one in the system path. Refs: ggml-org#2994 (comment)
This commit adds a check for the visionos build version used with vtool in build-xcframework.sh. The script now checks the Xcode version and determines whether to use "xros" or "visionos" for the build version. This commit also uses xcrun for the vtool so that the version of vtool in xcode command line tools is used instead of the one in the system path. Refs: #2994 (comment)
This commit adds a check for the visionos build version used with vtool in build-xcframework.sh. The script now checks the Xcode version and determines whether to use "xros" or "visionos" for the build version. This commit also uses xcrun for the vtool so that the version of vtool in xcode command line tools is used instead of the one in the system path. Refs: ggml-org/whisper.cpp#2994 (comment)
This commit adds a check for the visionos build version used with vtool in build-xcframework.sh. The script now checks the Xcode version and determines whether to use "xros" or "visionos" for the build version. This commit also uses xcrun for the vtool so that the version of vtool in xcode command line tools is used instead of the one in the system path. Refs: ggml-org/whisper.cpp#2994 (comment)
This commit adds a check for the visionos build version used with vtool in build-xcframework.sh. The script now checks the Xcode version and determines whether to use "xros" or "visionos" for the build version. This commit also uses xcrun for the vtool so that the version of vtool in xcode command line tools is used instead of the one in the system path. Refs: ggml-org/whisper.cpp#2994 (comment)
This commit adds a check for the visionos build version used with vtool in build-xcframework.sh. The script now checks the Xcode version and determines whether to use "xros" or "visionos" for the build version. This commit also uses xcrun for the vtool so that the version of vtool in xcode command line tools is used instead of the one in the system path. Refs: ggml-org/whisper.cpp#2994 (comment)
After that, we'll create a release from the Github UI, selecting this commit and creating a tag
v1.7.5.