Expose whisper_load_backends to make GGML_BACKEND_DL functional #3042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In retrospect it was a mistake to include the call to load the backends ( |
|
ggml_backend_load_all may be slight overkill but the multiple architectures for CPU is a benefit if doing a release especially in the case of x64. |
|
My suggestion would be:
|
|
whisper_load_backends can only be run once while ggml_backend_load_all has no such prevention |
|
OK, made this PR significantly better with ggml_backend_load_all and ggml_backend_load_best. |
danbev
added a commit
to danbev/whisper.cpp
that referenced
this pull request
May 28, 2025
This commit removes the `whisper_load_backends` function, which was used to load all GGML backends. The motivation for this change push the responsibility of loading backends to user applications to give them more control over which backends to load and when. See the references below for more context. Resolves: ggml-org#3182 Refs: ggml-org#3042 (comment) Refs: ggml-org#3042 (comment)
danbev
added a commit
that referenced
this pull request
May 29, 2025
* whisper : remove whisper_load_backends function This commit removes the `whisper_load_backends` function, which was used to load all GGML backends. The motivation for this change push the responsibility of loading backends to user applications to give them more control over which backends to load and when. See the references below for more context. Resolves: #3182 Refs: #3042 (comment) Refs: #3042 (comment) * ruby : add check for rwc is NULL This commit adds a check to ensure that the `rwc` pointer is not NULL before attempting to mark its members in the garbage collector. The motivation for this is an attempt to see if this fixed the CI build as I'm not able to reproduce the issue locally. Refs: https://github.com/ggml-org/whisper.cpp/actions/runs/15299612277/job/43036694928?pr=3196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2963
Added whisper_load_backends to whisper.h
Modified 3 examples (bench, cli and stream) to #ifdef GGML_BACKEND_DL call the function