-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ruby : omit test_build_options locally #3132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for maintaining even Ruby bindings.
Test for extra options is intended to detect removed options such as WHISPER_CCACHE
, but not intended to maintain platform differences. When I run tests and this test failures, I check pull requests and determine we should remove the options or just ignore the failure.
Now options for Ruby bindings is union of options for all platforms because I thought it's too hard for me to check and maintain options for every platform, and extra options hurt nothing.
If someone or automation matrix could check and maintain platform differences, it's good to do so. Is that possible? If not, how about to add comment to describe above and keep Options
class simple?
Could we simply remove the asserts from |
Okay, just remove it now. Later I will add a switch for my purpose later. |
Great, thanks! |
This commit omits the test for `test_build_options` when run locally as it currently fails on Linux and MacOS platforms. ` The motivation for this change is that currently when running the tests locally on a non-macOS platform the test fails with the following error: ```console .F ======================================================================== Failure: test_build_options(TestPackage): <["ACCELERATE_FRAMEWORK", "CMAKE_OSX_ARCHITECTURES", "CMAKE_OSX_SYSROOT", "FOUNDATION_LIBRARY", "METALKIT_FRAMEWORK", "METAL_FRAMEWORK"]> was expected to be empty. /home/danbev/work/ai/whisper.cpp/bindings/ruby/tests/test_package.rb:43:in `test_build_options' 40: options = BuildOptions::Options.new 41: assert_empty options.missing_options 42: unless ENV["CI"] => 43: assert_empty options.extra_options 44: end 45: end 46: end ======================================================================== ```
ruby : omit test_build_options locally
This commit omits the test for
test_build_options
when run locally asit currently fails on Linux and MacOS platforms.
The motivation for this change is that currently when running the tests
locally on a non-macOS platform the test fails with the following error: