Allow Vino + CoreML files to be in different directories, also optional switch to disable coreml for testing #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note - the disable_coreml switch -noml in whisper-bench is due to some testing I did yesterday on a M1 Mac 8Gb disable_coreml will at least allow selectively switching off CoreML when using a large model with a small device |
ggerganov
reviewed
May 14, 2025
Comment on lines
+14
to
+16
| std::string coreml_dir = ""; | ||
| std::string openvino_dir = ""; | ||
| bool disable_coreml = false; |
There was a problem hiding this comment.
This is not a good change - we should not pass backend-specific info through the libwhisper API.
There was a problem hiding this comment.
--ov-e-device in Cli appears rather backend specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the data files live in one directory - this gets confusing and hard to manage
This PR enables the openvino and coreml data files to be in other places than the same location as the main model
The parameters may be passed via whisper_context_params as path_coreml and path_openvino. If these are not supplied the current normal all-in-one-place scheme remains but if passed then these directories can be anywhere.
Also I added a disable_coreml parameter. This allows you to build with coreml but disable it on demand - useful for testing and debugging. This is a very simple bypass that merely skips over the coreml init function which has the same practical effect of not having coreml at all