Skip to content

ruby : add VAD support, migration to Ruby's newer API #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
May 28, 2025
Merged

ruby : add VAD support, migration to Ruby's newer API #3197

merged 35 commits into from
May 28, 2025

Conversation

KitaitiMakoto
Copy link
Collaborator

Hello,

This pull request for Ruby bindings includes:

  • VAD support
  • migration from Ruby's deprecated APIs to newer ones

Thank you.

@KitaitiMakoto
Add VAD models
06f3267
@KitaitiMakoto
Extract function to normalize model path from ruby_whisper_initialize()
86aac13
@KitaitiMakoto
Define ruby_whisper_vad_params struct
eb3b1bc
@KitaitiMakoto
Add VAD-related features to Whisper::Params
2f96162
@KitaitiMakoto
Add tests for VAD-related features
cf8465c
@KitaitiMakoto
Define Whisper::VADParams
944b2ac
@KitaitiMakoto
Add Whisper::VAD::Params attributes
46f9626
@KitaitiMakoto
Add test suite for VAD::Params
2fb49e1
@KitaitiMakoto
Make older test to follow namespace change
e3e25a8
@KitaitiMakoto
Add test for transcription with VAD
800b347
@KitaitiMakoto
Add assertion for test_vad_params
55f4d2e
@KitaitiMakoto
Add signatures for VAD-related methods
5a372d1
@KitaitiMakoto
Define VAD::Params#==
8b5a8f8
@KitaitiMakoto
Add test for VAD::Params#==
7400ba0
@KitaitiMakoto
Fix Params#vad_params
a12d759
@KitaitiMakoto
Add test for Params#vad_params
1981c30
@KitaitiMakoto
Fix signature of Params#vad_params
60a6ed1
@KitaitiMakoto
Use macro to define VAD::Params params
793a23a
@KitaitiMakoto
Define VAD::Params#initialize
04f72d5
@KitaitiMakoto
Add tests for VAD::Params#initialize
3436330
@KitaitiMakoto
Add signature for VAD::Params.new
fe75b22
@KitaitiMakoto
Add documentation on VAD in README
0d72f75
@KitaitiMakoto
Wrap register_callbask in prepare_transcription for clear meanings
14bec64
@KitaitiMakoto
Set whisper_params.vad_params just before transcription
0ec33e1
@KitaitiMakoto
Don't touch NULL
aaa293b
@KitaitiMakoto
Define ruby_whisper_params_type
684a680
@KitaitiMakoto
Use TypedData_XXX for ruby_whisper_params instead of Data_XXX
64b8b6f
@KitaitiMakoto
Remove unused functions
c2e9453
@KitaitiMakoto
Define rb_whisper_model_data_type
b2bf7f8
@KitaitiMakoto
Use TypedData_XXX for ruby_whisper_model instead of Data_XXX
d81efe4
@KitaitiMakoto KitaitiMakoto merged commit 1f5fdbe into ggml-org:master May 28, 2025
53 checks passed
@KitaitiMakoto KitaitiMakoto deleted the ruby-vad branch May 28, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbev danbev danbev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KitaitiMakoto @danbev