fix compilation with MSVC for arm64 with __ARM_NEON defined #3233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__fp16 is an undeclared identifie with MSVC
fix vaddlvq_s16 already defined as _CopyInt32FromFloat by MSVC arm64, and other similar functions
danbev
approved these changes
Jun 9, 2025
|
This is a bit complicated to explain, but the See ggml-org/ggml#1177 and references there. |
|
FWIW, with this patch it builds and it's properly running, doing speech to text as expected. I don't know if it actually uses NEON instructions though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 commits fix compilation errors when trying to build with MSVC arm64 with __ARM_NEON defined