This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Fixed Null Pointer exception on AST compilation#18
Open
Esposito-Matteo wants to merge 1 commit intoghaffarian:masterfrom
Open
Fixed Null Pointer exception on AST compilation#18Esposito-Matteo wants to merge 1 commit intoghaffarian:masterfrom
Esposito-Matteo wants to merge 1 commit intoghaffarian:masterfrom
Conversation
There was an unsafe assignment @ ex line 1935 where the result of the call to visit method was directly passed to the string buildere without checking for it's possibility to be null. The fix is as easy as it can be, it reports the null value and set it as an empty string, the reson behind it's null value should be looked into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
There was an unsafe assignment @ ex line 1935 where the result of the call to visit method was directly passed to the string builder without checking for it's possibility to be null. The fix is as easy as it can be, it reports the null value and set it as an empty string, the reson behind it's null value should be looked into it.
But as far as programwise now it works and gets to the end of the analysis even of big projects like the apache ones.
Another viable fix is to try-catch the error and act consequently.