fix: pre-set value for editor validation on paste

[zewa666]

hey there @ghiscoding

tbh I'm not sure why but with the latest update I've realized that the paste feature does no longer work for text/date fields defined with the editor.required: true. From the change you can see that the validation performs the check against the previous item state, so in order to make this work I needed to apply it in advance.

I really have no clue whether this used to work in a previous verison, can't remember if we checked that scenario explicitely, but I'd assume so. Moreover it only happens for TextEditors and the DateEditor, I couldn't replicate it on Booleans. Haven't checked the other editor types.

Any ideas what could have caused this? Was there perhaps a timing issue previously that caused this to work?

[zewa666]

you can replicate the issue by applying this change to Example19 in the editor config.

editor: { model: Editors.text, required: i === 5 ? true : false },

now copy a text from somewhere else, place the cursor into a cell of ColumnF, hit ESC to leave the editor mode and hit CTRL+V

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (44d9a52) to head (2653c85).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2363   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       24419    24419           
  Branches     8584     8584           
=======================================
  Hits        24419    24419           

Flag	Coverage Δ
angular	100.0% <ø> (ø)
universal	100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pkg-pr-new]

angular-slickgrid

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/angular-slickgrid@2363

aurelia-slickgrid

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/aurelia-slickgrid@2363

slickgrid-react

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/slickgrid-react@2363

slickgrid-vue

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/slickgrid-vue@2363

@slickgrid-universal/binding

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/binding@2363

@slickgrid-universal/common

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/common@2363

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/composite-editor-component@2363

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/custom-footer-component@2363

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/custom-tooltip-plugin@2363

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/empty-warning-component@2363

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/event-pub-sub@2363

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/excel-export@2363

@slickgrid-universal/graphql

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/graphql@2363

@slickgrid-universal/odata

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/odata@2363

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/pagination-component@2363

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/pdf-export@2363

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/row-detail-view-plugin@2363

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/rxjs-observable@2363

@slickgrid-universal/text-export

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/text-export@2363

@slickgrid-universal/utils

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/utils@2363

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/vanilla-bundle@2363

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/ghiscoding/slickgrid-universal/@slickgrid-universal/vanilla-force-bundle@2363

commit: 2653c85

[ghiscoding]

@zewa666 that might be because I'm migrating to the Hybrid Selection model which is now the only selection model available... ah wait you meant the last stable release, not the next branch, then I don't know

hey can you apply these changes on the next branch instead? I don't want to push code to the master branch until I release the Beta release, Then I'll merge next to master right after the Beta. There's too many conflicts every time, it's starting to be annoying

[zewa666]

yeah its affecting master, but right, I'll change target to next tomorrow. also need to come back to the other two open points

[ghiscoding]

sounds good, I think I'll do v10 Beta tomorrow after your PRs... no pressure haha. But even then I'm already working on a feature for v10.1, so if you can't make it then that's ok too

[zewa666]

closing in favor of #2368