refactor(presets): merge duplicate column preset loading logic #2364
+177
−241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate/similar code can be found in
changeColumnsArrangement()and in each framework wrappersloadColumnPresetsWhenDatasetInitialized(), this PR is removing this duplication by keeping onlychangeColumnsArrangement()from GridStateService which help removing duplicate code and stay DRY while decreasing build code size.The other great advantage was that the previous code
loadColumnPresetsWhenDatasetInitialized()was replicated in every framework wrappers, so centralizing the code in the GridStateService is helping removing so much duplicate code