shell-integration: better shell detection and setup #10044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#10035 will need a small update for this change (or vice-versa). I'll sort that out based on merge order. |
jparise
force-pushed
the
shell-integration-setup
branch
from
5ececaa to
012cde0
Compare
Contributor
Author
All set, thanks! |
Contributor
Author
@mitchellh everything look good? |
Contributor
|
Sorry haven't had a chance to look yet. I'll try to do it this week before anything else causes conflicts. 😄 |
Command-based shell detection has been extracted to its own function (detectShell), which is nicer for testing. It now uses argIterator to determine the command's executable, rather than the previous string operations, which allows us to handle command strings containing quotes and spaces. Also, our shell-specific setup functions now use a consistent signature, which simplifies the calling code quite a bit.
mitchellh
force-pushed
the
shell-integration-setup
branch
from
012cde0 to
795de79
Compare
mitchellh
approved these changes
Jan 7, 2026
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Just added type hints to the const. I prefer that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command-based shell detection has been extracted to its own function (detectShell), which is nicer for testing. It now uses argIterator to determine the command's executable, rather than the previous string operations, which allows us to handle command strings containing quotes and spaces.
Also, our shell-specific setup functions now use a consistent signature, which simplifies the calling code quite a bit.