Lower unimplemented OSC from warning to debug #10184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This was warning early on because it was a useful roadmap for what to implement to make the terminal functional, but we are very very long past that point and nowadays its mostly stuff we're purposely not implementing so this makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "unimplemented OSC command" warning is a frequent source of red herrings as there are many OSCs that we parse but deliberately do not implement. It's also a small drag on performance due to the function call overhead and the overhead of formatting and outputting the message. This PR lowers the message from warning to debug. Debug logs are compiled out of release builds so there should be less confusion from general users who will no longer see the message.