macOS: unset/reset keyboard shortcut for unbind and conflicts#12042
Closed
bo2themax wants to merge 7 commits intoghostty-org:mainfrom
Closed
macOS: unset/reset keyboard shortcut for unbind and conflicts#12042bo2themax wants to merge 7 commits intoghostty-org:mainfrom
unbind and conflicts#12042bo2themax wants to merge 7 commits intoghostty-org:mainfrom
Conversation
bo2themax
force-pushed
the
keyboard-responder
branch
from
fc45cbb to
daafbf1
Compare
# Conflicts: # macos/Tests/Ghostty/ConfigTests.swift
The structure is now nearly the same for upcoming changes. Although it goes through every single menu item in Ghostty main menu, but currently it still reset menu items registered AppDelegate, but will not change the ones not linked, like "Hide Ghostty".
Similar to ghostty-org#11396, if one is setting `keybind=cmd+option+h=goto_split:left`, the shortcut for "Hide Others" should be cleared out
bo2themax
force-pushed
the
keyboard-responder
branch
from
daafbf1 to
899b0f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #11995 and #12023.
This fixes
keybind=cmd+option+h=unbindnot working as expectkeybind=cmd+option+h=goto_split:leftnot hiding the shortcut on "Hide Others" and the menu is not highlighted