build: respect config.emit_xcframework for building libghostty-vt.xcframework on Darwin#12267
Open
0xDVC wants to merge 2 commits intoghostty-org:mainfrom
Open
build: respect config.emit_xcframework for building libghostty-vt.xcframework on Darwin#122670xDVC wants to merge 2 commits intoghostty-org:mainfrom
0xDVC wants to merge 2 commits intoghostty-org:mainfrom
Conversation
…ramework on Darwin This fixes a hardcoded build issue on macOS where Zig unconditionally forces xcodebuild -create-xcframework to run during compilation, even when the caller explicitly specifies that they only want the raw standard C objects/headers (-Demit-lib-vt). The Bug: Around line 155 in build.zig, the libghostty-vt xcframework was being packaged unconditionally for Darwin builds. This caused developers (and wrappers like go-libghostty) attempting to natively build the vt library locally using only the minimal macOS Command Line Tools to experience an immediate crash, as xcodebuild -create-xcframework strictly demands a full Xcode application installation. The Fix: Guarded the GhosttyLibVt xcframework creation step with config.emit_xcframework. Because src/build/Config.zig intuitively forces emit_xcframework to default to false whenever emit_lib_vt is invoked, this structurally allows lightweight macOS builds to safely skip the xcodebuild invocation while still correctly compiling the standard .a object library files.
Contributor
|
Hi @0xDVC, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
Contributor
|
!vouch |
Merged
ghostty-vouch bot
added a commit
that referenced
this pull request
Apr 13, 2026
Triggered by [comment](#12267 (comment)) from @mitchellh. Vouch: @0xDVC Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
kazto
pushed a commit
to kazto/ghostty
that referenced
this pull request
Apr 14, 2026
Triggered by [comment](ghostty-org#12267 (comment)) from @mitchellh. Vouch: @0xDVC Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mitchellh
approved these changes
Apr 14, 2026
Contributor
|
We've got some CI failures, we should look into it. I thought our swift example should have xcode and we should default emit xcframework to true. |
auto-merge was automatically disabled
April 14, 2026 18:00
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a hardcoded build issue on macOS where Zig unconditionally forces xcodebuild -create-xcframework to run during compilation, even when the caller explicitly specifies that they only want the raw standard C objects/headers (-Demit-lib-vt).