fix(sidecar): now properly highlighting selected heading on click#395
Merged
mitchellh merged 1 commit intoghostty-org:mainfrom Dec 2, 2025
Merged
Conversation
|
@matthew-hre is attempting to deploy a commit to the Ghostty Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #390
Based on the issue, it looks as though the headers are cut off at the top, which means that the IntersectionObserver was detecting the wrong heading, as the one clicked was "out of view"
A little bit of extra padding on the tops of the headings should do the trick!
Before:
Screencast_20251114_162044.webm
After:
Screencast_20251114_162148.webm