This repository was archived by the owner on Sep 7, 2020. It is now read-only.
Open
Conversation
I didnt really run a benchmark, so I wouldnt dare to say it would make any performance difference, but it might be more compact and catch all spelling variants. I also took the liberty to add the suggestion from https://news.ycombinator.com/item?id=20874138, though I left it commented out as these two terms are rather generic and might appear in many other contexts. PS: In this hip serverless world, I really appreciate that you are one of those who know how to choose the only correct way to indent code and place braces ;-D +1 PPS: My apologies for not placing a semicolon at the end, that is not because I dont believe there shouldnt be one ;) but most because for the commented `replace` calls :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didnt really run a benchmark, so I wouldnt dare to say it would make any performance difference, but it might be more compact and catch all spelling variants.
I also took the liberty to add the suggestion from https://news.ycombinator.com/item?id=20874138, though I left it commented out as these two terms are rather generic and might appear in many other contexts.
PS: In this hip serverless world, I really appreciate that you are one of those who know how to choose the only correct way to indent code and place braces ;-D +1
PPS: My apologies for not placing a semicolon at the end, that is not because I dont believe there shouldnt be one ;) but most because for the commented
replacecalls :)