Create karpenter custom resources in workload clusters #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
force-pushed
the
manage-karpenter-wc-crs
branch
2 times, most recently
from
dc1b90f to
e18c5b6
Compare
fiunchinho
force-pushed
the
manage-karpenter-wc-crs
branch
5 times, most recently
from
7355246 to
b81dc60
Compare
fiunchinho
changed the title
fiunchinho
force-pushed
the
manage-karpenter-wc-crs
branch
from
7ecbf14 to
bfa3f0c
Compare
fiunchinho
force-pushed
the
manage-karpenter-wc-crs
branch
from
bfa3f0c to
0482904
Compare
fiunchinho
force-pushed
the
manage-karpenter-wc-crs
branch
from
7367893 to
cc1af99
Compare
fiunchinho
commented
Jul 29, 2025
| conditions.MarkEC2NodeClassNotCreated(karpenterMachinePool, conditions.VersionSkewBlockedReason, message) | ||
| conditions.MarkNodePoolNotCreated(karpenterMachinePool, conditions.VersionSkewBlockedReason, message) | ||
|
|
||
| return fmt.Errorf("version skew policy violation: %s", message) |
There was a problem hiding this comment.
Should we requeue rather than return error?
There was a problem hiding this comment.
I changed it to requeue instead.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Checklist