Adapt Ignition user data S3 support to upstream PR #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See changes made in kubernetes-sigs#5172
fiunchinho
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changes made in kubernetes-sigs#5172
I have yet to test these changes. Our fork's default must remain to use S3 even if nothing is explicitly specified (see comment and custom change to
DefaultMachinePoolIgnitionStorageType). That's because cluster-aws didn't have it explicitly set before and the fix in giantswarm/cluster-aws#981 only applies to new CAPA cluster releases.Initial work was in giantswarm/roadmap#3442 and #592 (et al).