Skip to content

Conversation

@pipo02mix
Copy link
Contributor

Towards https://github.com/giantswarm/giantswarm/issues/32941

Basically, simplify the template and update some of the old config default files.

@pipo02mix pipo02mix requested a review from a team as a code owner March 26, 2025 15:34
@pipo02mix pipo02mix requested review from lyind and teemow March 26, 2025 15:34
@pipo02mix pipo02mix self-assigned this Mar 26, 2025
@teemow
Copy link
Member

teemow commented Mar 26, 2025

@pipo02mix I think the generated workflows shouldn't be in the template repository. It is anyway important that a new app is configured in giantswarm/github and those workflows get generated by the automation there.

@pipo02mix
Copy link
Contributor Author

ok I remove them :)

Copy link
Contributor

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Jonas Zeiger <jonas.zeiger@talpidae.net>
@pipo02mix pipo02mix merged commit 268b482 into main Mar 27, 2025
1 check was pending
@pipo02mix pipo02mix deleted the update-template branch March 27, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants