Skip to content

Conversation

@vidsinghal
Copy link
Collaborator

@vidsinghal vidsinghal commented Oct 9, 2023

This is experimental and needs review.
The instrumentation is enabled via a compile time command atm.
This is the latest version of PAPI that maintained.
This would need to be installed as a dependency to use --enable-papi

@vidsinghal
Copy link
Collaborator Author

@ulysses4ever any comments on this PR?

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance for:

  • a test showcasing the new flag; I understand numbers won't be stable across machines, but maybe there's a way to check that it's doing anything at all;

  • actual documentation.

I don't know where Gibbon prefers to store docs but the --help message is not sufficient. There should be an example.

I don't feel strongly about the test because, as I mentioned, it may be tricky, but I do feel strongly about the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants