Change itertimes in iterate to print in scientific format for high precision. #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@ulysses4ever is there anything holding from this PR to be merged? |
ulysses4ever
approved these changes
Jan 31, 2024
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
It'd be nice to have a test.
At the least, the PR description could show what the output looked like before the patch and what it is after the patch.
The PR description may be a place for the docs I mentioned in the other PR. It's not a great place but orders of magnitude better than nothing.
Collaborator
|
Also, CI is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.