Conversation
|
This is great! I will review it somewhere this week |
| @@ -144,12 +145,12 @@ class ScreenSaverService : DreamService(), MediaSliderListener { | |||
| } | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Could you create a new resource string for this error? string.set_albums_screensaver_error or something?
There was a problem hiding this comment.
Which line exactly are you referring to? I don't see any more untranslated strings in the ScreenSaverService.kt.
However, I found a few more hardcoded strings and added them to this PR as new commit.
There was a problem hiding this comment.
Previously, this was showing an error message with the text, please set the Immich albums to show in the settings (or something similar). Now it reuses the text from the settings itself, "set albums in screensaver"
|
I see a change in the MetaDataItem getTitle function so I guess this also requires a PR to MediasliderView? |
|
|
Thanks @HappyKoalaDev! I will install it on my local devices and draft up a release in the coming days. |
|
@giejay when can we expect the release? |
|
My apologies, I thought I released it already. It's now under review in the play store and should be available for the public in a few days. |
2 participants
Added multilingual support.
Closes #171