Add "Open in External Player" button to ExoPlayer video overlay#194
Draft
Add "Open in External Player" button to ExoPlayer video overlay#194
Conversation
Co-authored-by: giejay <2014373+giejay@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ability to open videos in external player
Add "Open in External Player" button to ExoPlayer video overlay
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal ExoPlayer can be laggy for certain videos. This adds a button to the video playback overlay that lets users open the current video in any installed video app (VLC, MX Player, etc.) via an Android chooser dialog.
Changes (in
mediaslidersubmodule)exo_player_control_view.xml): Addedexo_external_playerImageButtonat the end of the controls row with correct D-pad focus chain (slideshow↔external_player)ic_open_external.xml): New vector drawable — "open in new window" symbol, white fill to match existing buttonsExoPlayerView.kt: InitializesexternalPlayerBtnand routes its click to the existingonButtonClick(Int)callbackMediaSliderView.kt: HandlesR.id.exo_external_playerby callingopenInExternalPlayer(), which firesACTION_VIEWwithvideo/*on the current item's URL wrapped inIntent.createChooser; shows a toast if no app can handle itstrings.xml: Addedopen_in_external_player(chooser title) andno_external_player_found(fallback toast)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.9-bin/90cnw93cvbtalezasaz0blq0a/gradle-8.9/lib/gradle-daemon-main-8.9.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.9-bin/90cnw93cvbtalezasaz0blq0a/gradle-8.9/lib/agents/gradle-instrumentation-agent-8.9.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.9(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.