Add image overlay controller with favorite toggle for photo slider#196
Draft
Add image overlay controller with favorite toggle for photo slider#196
Conversation
…iewer Agent-Logs-Url: https://github.com/giejay/Immich-Android-TV/sessions/ca550969-e009-4e75-a6c7-a33e90493960 Co-authored-by: giejay <2014373+giejay@users.noreply.github.com>
Co-authored-by: giejay <2014373+giejay@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add context menu for adding images to favorites or albums
Add image overlay controller with favorite toggle for photo slider
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When viewing images in the slider, there was no way to interact with an asset (e.g., mark as favorite). Videos already had an overlay controller; images had none.
Changes
MediaSlider submodule
isFavorite: BooleantoSliderItemwith fullParcelablesupport.onFavoriteToggle: (String, Boolean) -> Unitcompanion callback onMediaSliderConfiguration(same pattern asonAssetSelected).image_controller.xml(favorite + slideshow buttons),ic_favorite.xml,ic_favorite_border.xml.isControllerVisible()now also returnstruewhen the image overlay is visible (preserves screensaver dismiss behavior).App
AssetgainsisFavorite: Boolean = false;AssetUtil.toSliderItem()forwards it.ApiService: newPUT assets/{id}endpoint via Retrofit.ApiClient.updateFavorite(id, isFavorite)wraps the call.ImmichMediaSlidersetsMediaSliderConfiguration.onFavoriteToggleto callupdateFavoriteand show a toast on success/failure.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.9-bin/90cnw93cvbtalezasaz0blq0a/gradle-8.9/lib/gradle-daemon-main-8.9.jar -javaagent:/home/REDACTED/.gradle/wrapper/dists/gradle-8.9-bin/90cnw93cvbtalezasaz0blq0a/gradle-8.9/lib/agents/gradle-instrumentation-agent-8.9.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.9(dns block)/usr/bin/curl curl -s REDACTED grep -l(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.prefs/java.util.prefs=ALL-UNNAMED --add-opens java.prefs/java.util.prefs=ALL-UNNAMED --add-opens java.base/java.nio.charset=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED --add-opens java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx1536m(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.