fix: update address handling in AdditionalAddress and Contact classes to clarify deprecation and exclude address from create/update requests

Author: mgjgid

src/Resources/Contacts/AdditionalAddresses/AdditionalAddress.php

@@ -23,8 +23,8 @@ class AdditionalAddress extends Resource
     const QUERY_BUILDER = AdditionalAddressQueryBuilder::class;
 
 
-    /** @deprecated use street_name, house_number, address_addition instead. */
-    public ?string $address;
+    /** @deprecated use street_name, house_number, address_addition instead. This property is not included in the create and update requests. */
+    public ?string $address = null;
 
     public function __construct(
         public ?int $id = null,

src/Resources/Contacts/AdditionalAddresses/Requests/CreateAdditionalAddressRequest.php

@@ -29,7 +29,7 @@ public function resolveEndpoint(): string
 
     protected function defaultBody(): array
     {
-        return $this->additionalAddress->except("id", "contact_id")->toArray();
+        return $this->additionalAddress->except("id", "contact_id", 'address')->toArray();
     }
 
     public function createDtoFromResponse(Response $response): AdditionalAddress

src/Resources/Contacts/AdditionalAddresses/Requests/UpdateAdditionalAddressRequest.php

@@ -29,7 +29,7 @@ public function resolveEndpoint(): string
 
     protected function defaultBody(): array
     {
-        return $this->additionalAddress->except("id", "contact_id")->toArray();
+        return $this->additionalAddress->except("id", "contact_id", 'address')->toArray();
     }
 
     public function createDtoFromResponse(Response $response): AdditionalAddress

src/Resources/Contacts/Contacts/Contact.php

@@ -33,8 +33,8 @@ class Contact extends Resource
     public ?string $updated_at;
     public ?string $profile_image;
 
-    /** @deprecated use street_name, house_number, address_addition instead. */
-    public ?string $address;
+    /** @deprecated use street_name, house_number, address_addition instead. This property is not included in the create and update requests. */
+    public ?string $address = null;
 
     public function __construct(
         public int|ContactType $contact_type_id = ContactType::COMPANY,

src/Resources/Contacts/Contacts/Requests/CreateContactRequest.php

@@ -29,7 +29,7 @@ public function resolveEndpoint(): string
 
     protected function defaultBody(): array
     {
-        return $this->contact->except("updated_at", "profile_image")->toArray();
+        return $this->contact->except("updated_at", "profile_image", 'address')->toArray();
     }
 
     public function createDtoFromResponse(Response $response): Contact

src/Resources/Contacts/Contacts/Requests/UpdateContactRequest.php

@@ -34,7 +34,7 @@ public function createDtoFromResponse(Response $response): Contact
 
     protected function defaultBody(): array
     {
-        return $this->contact->except( "updated_at", "profile_image")->toArray();
+        return $this->contact->except("updated_at", "profile_image", 'address')->toArray();
     }
 
 }

tests/Resources/Contacts/AdditionalAddresses/AdditionalAddressRequestsTest.php

@@ -10,12 +10,10 @@
 
 it('can create an AdditionalAddress', function () use (&$testAddress) {
     $address = new AdditionalAddress(
-        id: null,
         contact_id: testContactId(),
         name: fake()->word(),
         street_name: fake()->streetName(),
         house_number: fake()->buildingNumber(),
-        address_addition: fake()->secondaryAddress(),
         postcode: fake()->postcode(),
         city: fake()->city(),
         subject: fake()->sentence(),