Extend fromPredicate type to support type guards#755
Merged
gigobyte merged 2 commits intogigobyte:masterfrom Nov 13, 2025
Merged
Extend fromPredicate type to support type guards#755gigobyte merged 2 commits intogigobyte:masterfrom
gigobyte merged 2 commits intogigobyte:masterfrom
Conversation
Owner
|
I believe instead of a new method, you can add it as a function overload on fromPredicate, like how the types for Array.filter are implemented: filter<S extends T>(predicate: (value: T, index: number, array: T[]) => value is S, thisArg?: any): S[];
filter(predicate: (value: T, index: number, array: T[]) => unknown, thisArg?: any): T[]; |
Contributor
Author
true dat! |
gigobyte
requested changes
Nov 13, 2025
5fa2246 to
e050425
Compare
gigobyte
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.