fix(Codec): fix crash on prototype-less objects#756
Merged
gigobyte merged 1 commit intogigobyte:masterfrom Dec 11, 2025
Merged
Conversation
- Replace `input.hasOwnProperty(key)` with `Object.prototype.hasOwnProperty.call(input, key)` in `Codec.ts`. This prevents runtime errors when decoding objects created via `Object.create(null)`. - Add regression tests for prototype-less objects. - Apply formatting and linting fixes to `Maybe.ts` and `Maybe.test.ts`.
Owner
|
Thanks for the contribution, I will release it today by end of day. 😊 |
Contributor
Author
|
Thanks for merging, a release would be great as this could potentially also lead to a DoS attack (by providing json objects with the key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input.hasOwnProperty(key)withObject.prototype.hasOwnProperty.call(input, key)inCodec.ts. This prevents runtime errors when decoding objects created viaObject.create(null).Maybe.tsandMaybe.test.ts.