Skip to content

security: harden input validation#5

Open
gilby125 wants to merge 1 commit intofix/lxc-node-assignment-minimalfrom
security/harden-input-validation
Open

security: harden input validation#5
gilby125 wants to merge 1 commit intofix/lxc-node-assignment-minimalfrom
security/harden-input-validation

Conversation

@gilby125
Copy link
Owner

@gilby125 gilby125 commented Feb 8, 2026

Stacked on PR #4.

Security hardening:

  • Require PROXMOX_HOST and PROXMOX_TOKEN_VALUE instead of using defaults.
  • Add validators for storage, snapshot, disk, mount point, network, and bridge identifiers.
  • Apply validators across backup/snapshot/disk/network operations before building API paths/bodies.
  • Remove unnecessary npm "https" dependency (Node builtin is used).
  • Fix generateSecurePassword() to avoid modulo bias (uses crypto.randomInt).

Notes:

  • Unit test sets required env vars so it doesn't depend on a local .env.

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch security/harden-input-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant