Skip to content

Potential fix for NULL Pointer Dereference #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Potential fix for NULL Pointer Dereference #337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d66942a
Potential fix for code scanning alert no. 1: Redundant null check due…
Johan-p Oct 21, 2025
64b12d7
Merge pull request #1 from Johan-p/Sec-alert-fix-1
Johan-p Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UI/BaseDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ void UIElement::MeasureTextVSize(const char* text, int* width, int* height, HWND
assert(wnd);

// get control's width
int w = *width;
int w = width ? *width : -1;
if (w < 0)
{
//!! see AllocateUISpace() for details, should separate common code in some way
Expand Down